Update SQLite.swift to version 13.1 #2015

Iron-Ham · 2021-11-02T22:42:42Z

Overview

This PR:

Updates the version of SQLite being used in Apollo-iOS to version 13.0

What do we get by upgrading to version 13.0?

The release notes for version 13.0 aren't super descriptive (Support for Xcode 12 and iOS 14 + fixes) but version 13.0 includes new table functionality for SQLite.swift, such as upsert and insertMany.

I know that y'all are planning on switching out SQLite.swift for GRDB or FMDB, but this a small quality of life improvement for those of us who are also using SQLite.swift in our application which depend upon Apollo.

What should we test?

Everything... should be the same? The diff between versions is fairly small and concerns around next() and failableNext() don't seem to impact Apollo since we're using map and not next() or failableNext() directly.

apollo-cla · 2021-11-02T22:42:44Z

@Iron-Ham: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

designatednerd · 2021-11-02T23:15:50Z

FWIW the switch has been back-burnered for a bit until we get codegen done. I seem to remember @calvincestari looking into this and there was some reason it wasn't going to work...Calvin, care to elaborate?

calvincestari · 2021-11-03T00:56:33Z

Hi @Iron-Ham, thanks for the PR - 👋🏻

Your PR doesn't appear to update the Xcode package dependency for SQLite.swift. Opening the project you'll notice it's still only fetching 0.12.2 - that'll need to be updated too.

Everything... should be the same? The diff between versions is fairly small and concerns around next() and failableNext() don't seem to impact Apollo since we're using map and not next() or failableNext() directly.

We switched to prepareRowIterator in #1917 because internally it uses failableNext and the change in 0.12.2 would have hidden errors. After we'd merged our change I see they reversed the change in SQLite.swift but I still believe failableNext is the correct choice because the old behaviour (now current again) will crash an app on error with try!.

@designatednerd is correct, I did look at updating to SQLite.swift 0.13.0 a while ago and we made a decision to defer it. We made that decision because of the bump to the minimum macOS deployment target from 10.10 to 10.15.

While bumping to macOS 10.15 isn't impactful to the ApolloSQLite target it is for the ApolloWebSocket target because a bunch of the Security.framework API was deprecated. If you only ever built apollo-ios for the iOS platform you would be fine and never know about this because the minimum iOS deployment target for apollo-ios and SQLite.swift is 12.0 and 9.0 respectively.

Some thoughts:

I'm not 100% sure of the impact with supporting divergent macOS deployment targets for ApolloSQLite and ApolloWebSocket.
I'm confused why I don't get a warning when building ApolloSQLite for macOS where SQLite.swift requires 10.15 but apollo-ios still has a minimum of 10.14?
We are planning to rewrite the WebSocket implementation in apollo-ios 2.0, in amongst a larger network stack overhaul. That change will likely include us updating to minimum deployment targets of 13.0 for iOS and 10.15 for macOS. That's not to say we can't find a resolution to your issue now, I'm sharing where we had deferred the SQLite.swift update to.

designatednerd · 2021-11-03T03:47:09Z

I'm confused why I don't get a warning when building ApolloSQLite for macOS where SQLite.swift requires 10.15 but apollo-ios still has a minimum of 10.14?

Is that after you've updated the xcodeproj to try to use 0.13.0? Otherwise I don't think it'll try to fetch.

designatednerd · 2021-11-03T15:53:55Z

My least favorite category of thing to solve: It works, I have no idea why.

Iron-Ham · 2021-11-03T16:02:38Z

I've been trying to figure out why this is working all morning, and I don't understand.

calvincestari · 2021-11-03T18:06:25Z

I'm confused why I don't get a warning when building ApolloSQLite for macOS where SQLite.swift requires 10.15 but apollo-ios still has a minimum of 10.14?

Is that after you've updated the xcodeproj to try to use 0.13.0? Otherwise I don't think it'll try to fetch.

@designatednerd yes. I verified it was showing 0.13.0 as the dependency version in Xcode and the updated hash in the diff is 9af51e2edf491c0ea632e369a6566e09b65aa333.

Iron-Ham · 2021-11-03T19:03:27Z

Sticking this in draft.
Context: Over Slack, we realized that this is working when built using SPM, but not so much when using CocoaPods. That's because in SQLite.Swift's update to 0.13.0, they updated the minimum version requirement in the podspec. There are no declared minimums in the Package.swift file.

calvincestari · 2021-11-03T20:21:21Z

Over Slack, we realized that this is working when built using SPM, but not so much when using CocoaPods.

Correct. When setting up a project with Cocoapods you get the expected warning due to the version mismatch.

Analyzing dependencies
Pre-downloading: `Apollo` from `https://github.com/Iron-Ham/apollo-ios.git`, branch `hs/update-sqliteswift`
[!] CocoaPods could not find compatible versions for pod "SQLite.swift":
  In Podfile:
    Apollo/SQLite (from `https://github.com/Iron-Ham/apollo-ios.git`, branch `hs/update-sqliteswift`) was resolved to 0.49.1, which depends on
      SQLite.swift (~> 0.13.0)

Specs satisfying the `SQLite.swift (~> 0.13.0)` dependency were found, but they required a higher minimum deployment target.

I've submitted a PR to SQLite.swift to get platform versions added to the SPM manifest. Hopefully this should give SPM the details it needs to give similar warnings.

calvincestari · 2021-11-05T20:19:03Z

OK, we've gotten that PR on SQLite.swift merged and I'm following up with the originator of the macOS version change to see if it's actually needed; maybe we can get it rolled back.

calvincestari · 2021-11-10T00:21:31Z

Good news - the change to require macOS 10.15 was reverted. As soon as they publish another release we can get this PR merged after resolving to that new version.

calvincestari · 2021-11-15T18:29:36Z

I've added this PR to our 'Next Release' project. If SQLite.swift publishes their next release before we do we'll get this change included, for now it's pending.

Iron-Ham · 2021-11-15T19:27:46Z

Thanks @calvincestari ! I really appreciate all of the follow-up you've been doing related to this PR, and I especially appreciate the follow-through with the SQLite.swift folks.

❤️

This ensures all macOS targets can build with the reverted deployment target.

calvincestari · 2021-11-17T19:54:03Z

@Iron-Ham I've just bumped the minimum required version to 0.13.1 with the SQLite.swift release today. Once the tests on this updated PR pass I'll get it merged and we will release 0.50.0 of apollo-ios today with this included. 🎉

* Update version number for release * Updated changelog for release * Update documentation for release changes * Update changelog for #2015

Squashed commit of the following: commit 3262cd0 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Nov 18 03:49:51 2021 +0000 fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.8 (#2038) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit d93568f Author: Calvin Cestari <calvincestari@users.noreply.github.com> Date: Wed Nov 17 12:51:58 2021 -0800 Release `0.50.0` (#2031) * Update version number for release * Updated changelog for release * Update documentation for release changes * Update changelog for #2015 commit 46957a3 Author: Hesham Salman <iron-ham@github.com> Date: Wed Nov 17 15:15:54 2021 -0500 Update SQLite.swift to version 13.0 (#2015) * Update Package.swift and podspec * Updated XcodeProj * Bump SQLite.swift minimum required version to 0.13.1 Co-authored-by: Calvin Cestari <calvin.cestari@gmail.com> commit 8d48031 Author: hwillson <hugh@octonary.com> Date: Fri Nov 12 16:24:18 2021 -0500 Gateway clarification based on license change commit 55c5db8 Author: Calvin Cestari <calvincestari@users.noreply.github.com> Date: Fri Nov 12 10:47:33 2021 -0800 Update apollo-tooling to v2.33.9 (#2028) * Update to v2.33.9 of the CLI tooling * Update StarWarsAPI output generated by updated tooling * Update test with expected output * Keep the parameter spacing commit ece5b5b Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Nov 10 22:13:58 2021 +0000 fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.6 (#2026) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit a8a35ae Author: Anthony Miller <anthonymdev@gmail.com> Date: Tue Nov 9 11:50:36 2021 -0800 Attempted fix for integration test failing on CI (#2024) commit a1e857c Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Nov 8 16:24:21 2021 -0800 Bump apollo-server from 2.16.1 to 2.25.3 in /SimpleUploadServer (#2020) Bumps [apollo-server](https://github.com/apollographql/apollo-server/tree/HEAD/packages/apollo-server) from 2.16.1 to 2.25.3. - [Release notes](https://github.com/apollographql/apollo-server/releases) - [Changelog](https://github.com/apollographql/apollo-server/blob/main/CHANGELOG.md) - [Commits](https://github.com/apollographql/apollo-server/commits/apollo-server@2.25.3/packages/apollo-server) --- updated-dependencies: - dependency-name: apollo-server dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6bf4362 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue Nov 9 00:03:55 2021 +0000 fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.2 (#2021) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 3bfde02 Author: Mike Pitre <mikepitre1@gmail.com> Date: Mon Nov 8 13:58:36 2021 -0500 GET method for `ApolloSchemaDownloader` (#2010) * GET method for ApolloSchemaDownloader * Minor improvements to HTTP method enum * Remove ApolloSchemaDownload scope from name * Add documentation * Add HTTP method string constants as output * Add error for unsupported HTTP method when using Apollo Registry * Move HTTP method support into DownloadMethod * Build requests based on DownloadMethod * Add tests for DownloadMethod HTTP method configurations * Clean up and clarify documentation * Add associated values to URL-related errors Co-authored-by: Calvin Cestari <calvin.cestari@gmail.com> commit 9cab672 Author: Calvin Cestari <calvincestari@users.noreply.github.com> Date: Wed Nov 3 12:48:57 2021 -0700 Expose `cacheKey` function as `public` (#2014) * Expose cacheKey function as public * Remove @testable attribute to require public access to cacheKey function commit f2a4983 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Oct 28 01:40:10 2021 +0000 fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.1 (#2006) Co-authored-by: Renovate Bot <bot@renovateapp.com>

@designatednerd

* Attempted fix for integration test failing on CI (apollographql#2024) * fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.6 (apollographql#2026) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update apollo-tooling to v2.33.9 (apollographql#2028) * Update to v2.33.9 of the CLI tooling * Update StarWarsAPI output generated by updated tooling * Update test with expected output * Keep the parameter spacing * Gateway clarification based on license change * Update SQLite.swift to version 13.0 (apollographql#2015) * Update Package.swift and podspec * Updated XcodeProj * Bump SQLite.swift minimum required version to 0.13.1 Co-authored-by: Calvin Cestari <calvin.cestari@gmail.com> * Release `0.50.0` (apollographql#2031) * Update version number for release * Updated changelog for release * Update documentation for release changes * Update changelog for apollographql#2015 * fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.8 (apollographql#2038) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update caching.mdx (apollographql#2042) fixed typo * Update ROADMAP.md (apollographql#2053) * Clean up Github API for performance tests * fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.9 (apollographql#2062) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Make filesystem diagram a bit easier to understand (apollographql#2063) * Update ASCII art for filesystem, clarify where Apollo Codegen folder goes * update spacing to make comments clearer, fix missing file emoji * Allow periods in arguments to be ignored when parsing cacheKeys (apollographql#2057) * Allow commas in arguments to be ignored when parsing cacheKeys * Update * More tests * No-split case * fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.11 (apollographql#2068) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.12 (apollographql#2074) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Add tutorial on subscriptions to match Android (apollographql#2072) * Remove bits from under construction that are going to be handled with blog posts, update versions * Get rid of fragments and cache, bring over android subscriptions stuff * this is actually part 9 on iOS * bring over screenshots from Android tutorial * Correct link * Update everything for iOS * update index and link from prior step to include subscriptions * Fix link to subscriptions * add missing image * fix borked link * be clearer about replacing the print statement * remove "unnecessary" quotation marks * add missing sentence, make image less ginormous * Fix direction I definitely know my left from my right! :woman-facepaming: Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com> * add missing word Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com> * Bump mermaid from 8.13.6 to 8.13.8 in /docs (apollographql#2083) Bumps [mermaid](https://github.com/knsv/mermaid) from 8.13.6 to 8.13.8. - [Release notes](https://github.com/knsv/mermaid/releases) - [Changelog](https://github.com/mermaid-js/mermaid/blob/develop/docs/CHANGELOG.md) - [Commits](mermaid-js/mermaid@8.13.6...8.13.8) --- updated-dependencies: - dependency-name: mermaid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): update dependency engine.io to 4.1.2 [security] (apollographql#2094) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency follow-redirects to 1.14.7 [security] (apollographql#2092) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency node-forge to 1.0.0 [security] (apollographql#2095) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Add note about acceptable extensions for types of schema file. (apollographql#2059) * Docs: Bump to Gatsby v3 (apollographql#2104) * Bump gatsby to v3, bump docs theme to version that supports v3 * Bump docs theme to latest prerelease for gatsby v3 * Bump docs theme to new major version * fix(deps): pin dependency gatsby-theme-apollo-docs to 6.0.0 (apollographql#2113) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix(deps): pin dependency gatsby to 3.14.6 (apollographql#2123) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Edits to intro and installation docs (apollographql#2125) * Edits to intro and installation docs * Fix broken links * Edits from @designatednerd plus new screenshots * Fix tutorial URL and tweak downloading a schema article (apollographql#2133) * Split advanced "Creating a client" content into separate article (apollographql#2143) * WIP on revamp to Creating a client article * Break request chain content into separate article * Fix broken links * Incorporate feedback * Disable flaky integration test Will go back and fix this during WebSocket updates after 1.0 alpha * Update gatsby config to deploy 1.0 alpha docs * Update roadmap after 1.0.0-alpha.1 release (apollographql#2145) * [v1.0.0 Alpha 1] JavascriptError @unchecked Sendable (apollographql#2147) * fix: added unchecked sendable to JavascriptError to be able to compile with Swift 5.6 * Update CircleCI to use latest images * Change JavaScriptError properties to read-only * Fix typo in header doc Co-authored-by: TizianoCoroneo <tizianocoroneo@me.com> Co-authored-by: Calvin Cestari <calvin.cestari@gmail.com> * Update documentation to clarify schema download format and filename (apollographql#2160) * Update documentation to clarify schema download format and filename * Fix documentation link * chore(deps): update dependency follow-redirects to 1.14.8 [security] (apollographql#2161) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update license copyright notice * Delete Jazzy config - not supported * Update list of active maintainers * [Fix apollographql#2170] Do not refetch query watcher from server after cache miss when cache policy is cache only (apollographql#2177) * [Fix apollographql#2170] Do not refetch query watcher from server after cache miss when cache policy is cache only * Revert test broken test infra change * Add `graphql-ws` protocol support (apollographql#2168) * Implement graphql-transport-ws protocol support * Add graphql-transport-ws integration test based on Apollo Server docs-examples * Add CI step for Apollo Server graphql-transport-ws tests * After installing node v12 switch to use v16 * Instruct nvm to use version in .nvmrc * Update documentation and tutorial * Change WSProtocol cases to closer match library names * Remove initializer defaults and require web socket protocol on designated initializer. * Update Subscriptions documentation * Add WSProtocol option for AWS AppSync * Add ping/pong message support required by graphql-ws * Update documentation and tutorial * Add tests for subscriptionWsProtocol * Add tests for graphqlWSProtocol * Revert to naming aligned with the protocols and not the implementation libraries * Use longer async timeout for slower environments like CI * Fix test names * Fix project configuration * Rename protocol parameter on WebSocket initializers * Revert "Use longer async timeout for slower environments like CI" * Fix async timing bug and refactor websocket protocol tests * chore(deps): update dependency prismjs to 1.27.0 [security] (apollographql#2179) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Release 0.51.0 (apollographql#2086) * Update version number * Update changelog * Update SourceDocsLib dependecy * Update generated documentation * Update changelog with cache key caveat * Update changelog for merging of apollographql#2147 * Update changelog for apollographql#2177 and apollographql#2168 * Update documentation * Enable lazy access to the request body creation for leverage in custom built interceptors (apollographql#2184) * Release `0.51.1` (apollographql#2188) * Update project version * Update changelog for apollographql#2184 * Update documentation * Updates for new docs infra (apollographql#2197) * Prepare ios docs for new infra * Add sidebar config * Update ExpansionPanelList components * Update code fences * Move _redirects file * Fix links * Update docset title * Update sidebar config * Add version to ios docs config * Remove imports and fix links * Remove mb from homepage button * Add algolia filters * Remove files from old Gatsby docs theme (apollographql#2202) * Remove files from old Gatsby docs theme * Remove netlify.toml * Clear body on APQ retry in JSONRequest (apollographql#2206) * Release 0.51.2 (apollographql#2207) * Release 0.51.2 * Fix Package file * Fix changelog version. * Add netlify config for deploy previews (apollographql#2208) * Add netlify config for deploy previews * Trigger deploy * Remove circle config * Update docs repo branch * Use buttonlink component * Add codegen option for excludes (apollographql#2205) * Add exclude options * Add test case * Fix typo (apollographql#2212) * Start a docs production deploy when docs changes get merged (apollographql#2211) * Create docs-publish.yml * Tweak ignore command * Bump minimist from 1.2.5 to 1.2.6 in /SimpleUploadServer (apollographql#2214) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump node-fetch from 2.6.6 to 2.6.7 in /SimpleUploadServer (apollographql#2215) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.6 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.6...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add note to tutorial about the `graphql-ws` subscription library (apollographql#2219) * Add note to tutorial about new subscription library * tweak spacing * tweak phrasing * Add links and clarify which library is not maintained Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com> * Update tutorial-obtain-schema.md (apollographql#2225) Change extension of the downloaded schema file. * Update tutorial-execute-query.md (apollographql#2228) * Update tutorial-execute-query.md * Change the schema file type to json. * chore: Update Xcode build tool versions on CircleCI (apollographql#2242) * chose: update xcode build environment versions * fix: update Node version to match CircleCI image * chore: Update roadmap * fix: Sandbox documentation links (apollographql#2254) * ci: Update xcode image to fix Node version mismatch * ci: Update Node version to match what is installed with Xcode 13.3.1 image * chore: updates roadmap (apollographql#2258) * chore: updates roadmap * Update ROADMAP.md Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com> * Update ROADMAP.md Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com> Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com> * Update build phases example to propagate errors to Xcode (apollographql#2260) Without the explicit propagation I wasn't seeing errors in Xcode. Build phase shell env: `/bin/sh` Xcode version: `Version 13.2.1 (13C100)` * Add a comment about a new use of the X-APOLLO-OPERATION-NAME header (apollographql#2267) * Set permissions for GitHub actions (apollographql#2248) * updates roadmap for june 2022 (apollographql#2295) * Update CircleCI tool versions (apollographql#2304) * ci: Update Xcode and iOS simulator versions * ci: Update Node version * fix: `graphql_transport_ws` protocol should send 'complete' to end subscription (apollographql#2320) * fix: graphql_transport_ws protocol should send 'complete' to end subscription * fix: Require MockWebSocket to be initialized with a graphql subscriptions protocol * tests: Fix StarWarsSubscriptionTests to use updated MockWebSocket initializer * Replace print statement with CodegenLogger.log (apollographql#2348) * Fix buttons on docs root (apollographql#2369) * Expose GraphQLResultError Path String (apollographql#2361) * Expose the path as a String * tests: Add unit tests for ResponsePath Co-authored-by: Calvin Cestari <calvin.cestari@gmail.com> * Revert "Fix buttons on docs root (apollographql#2369)" (apollographql#2371) This reverts commit d26751a. * release: 0.52.0 (apollographql#2370) * chore: Update release version number * chore: Update changelog * dep: Update packages * docs: Update API reference * Fix typo (apollographql#2379) Removed duplicate "the" * Fix incorrect parameter name (apollographql#2380) `id` was set as a parameter, but the query expects `launchId`. * chore: Update ROADMAP for Beta release cycle (apollographql#2393) * Remove all instances of bitcode as not supported in Xcode 14 (apollographql#2398) https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes * Release 0.53.0 (apollographql#2406) * chore: Update version number * chore: Update CHANGELOG * fix: checkout at tag with legacy optionals behavior (apollographql#2412) * Update version in Swift Scripting docs (apollographql#2416) * Re-added support for iOS 11 Co-authored-by: Anthony Miller <anthonymdev@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com> Co-authored-by: hwillson <hugh@octonary.com> Co-authored-by: Hesham Salman <iron-ham@github.com> Co-authored-by: Calvin Cestari <calvin.cestari@gmail.com> Co-authored-by: bogdanbeczkowski <bogdanbeczkowski@gmail.com> Co-authored-by: Ellen Shapiro <designatednerd@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Janessa Garrow <janessa@apollographql.com> Co-authored-by: Stephen Barlow <stephen@apollographql.com> Co-authored-by: TizianoCoroneo <tizianocoroneo@me.com> Co-authored-by: Calvin Cestari <calvin.cestari@apollographql.com> Co-authored-by: Rick Fast <rfast@expediagroup.com> Co-authored-by: Trevor Blades <tdblades@gmail.com> Co-authored-by: bannzai <kingkong999yhirose@gmail.com> Co-authored-by: Ayden Lee <lcmini6528@gmail.com> Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> Co-authored-by: Carrione <miroslav.tourek@gmail.com> Co-authored-by: Martin Bonnin <martin@mbonnin.net> Co-authored-by: JV <jvajda@apollographql.com> Co-authored-by: Adam Zethraeus <adam@zethrae.us> Co-authored-by: David Glasser <glasser@apollographql.com> Co-authored-by: neilnaveen <42328488+neilnaveen@users.noreply.github.com> Co-authored-by: Hilton Campbell <github@crosswaterbridge.com> Co-authored-by: Joshua Shroyer <98055534+joshuashroyer-toast@users.noreply.github.com> Co-authored-by: Mischa Hildebrand <web@mischa-hildebrand.de> Co-authored-by: stareque-atlassian <46062249+stareque-atlassian@users.noreply.github.com> Co-authored-by: Yuki Yamamoto <yymmt3.waste@gmail.com>

@designatednerd

* Attempted fix for integration test failing on CI (apollographql#2024) * fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.6 (apollographql#2026) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update apollo-tooling to v2.33.9 (apollographql#2028) * Update to v2.33.9 of the CLI tooling * Update StarWarsAPI output generated by updated tooling * Update test with expected output * Keep the parameter spacing * Gateway clarification based on license change * Update SQLite.swift to version 13.0 (apollographql#2015) * Update Package.swift and podspec * Updated XcodeProj * Bump SQLite.swift minimum required version to 0.13.1 Co-authored-by: Calvin Cestari <calvin.cestari@gmail.com> * Release `0.50.0` (apollographql#2031) * Update version number for release * Updated changelog for release * Update documentation for release changes * Update changelog for apollographql#2015 * fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.8 (apollographql#2038) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update caching.mdx (apollographql#2042) fixed typo * Update ROADMAP.md (apollographql#2053) * Clean up Github API for performance tests * fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.9 (apollographql#2062) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Make filesystem diagram a bit easier to understand (apollographql#2063) * Update ASCII art for filesystem, clarify where Apollo Codegen folder goes * update spacing to make comments clearer, fix missing file emoji * Allow periods in arguments to be ignored when parsing cacheKeys (apollographql#2057) * Allow commas in arguments to be ignored when parsing cacheKeys * Update * More tests * No-split case * fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.11 (apollographql#2068) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.12 (apollographql#2074) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Add tutorial on subscriptions to match Android (apollographql#2072) * Remove bits from under construction that are going to be handled with blog posts, update versions * Get rid of fragments and cache, bring over android subscriptions stuff * this is actually part 9 on iOS * bring over screenshots from Android tutorial * Correct link * Update everything for iOS * update index and link from prior step to include subscriptions * Fix link to subscriptions * add missing image * fix borked link * be clearer about replacing the print statement * remove "unnecessary" quotation marks * add missing sentence, make image less ginormous * Fix direction I definitely know my left from my right! :woman-facepaming: Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com> * add missing word Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com> * Bump mermaid from 8.13.6 to 8.13.8 in /docs (apollographql#2083) Bumps [mermaid](https://github.com/knsv/mermaid) from 8.13.6 to 8.13.8. - [Release notes](https://github.com/knsv/mermaid/releases) - [Changelog](https://github.com/mermaid-js/mermaid/blob/develop/docs/CHANGELOG.md) - [Commits](mermaid-js/mermaid@8.13.6...8.13.8) --- updated-dependencies: - dependency-name: mermaid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): update dependency engine.io to 4.1.2 [security] (apollographql#2094) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency follow-redirects to 1.14.7 [security] (apollographql#2092) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency node-forge to 1.0.0 [security] (apollographql#2095) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Add note about acceptable extensions for types of schema file. (apollographql#2059) * Docs: Bump to Gatsby v3 (apollographql#2104) * Bump gatsby to v3, bump docs theme to version that supports v3 * Bump docs theme to latest prerelease for gatsby v3 * Bump docs theme to new major version * fix(deps): pin dependency gatsby-theme-apollo-docs to 6.0.0 (apollographql#2113) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix(deps): pin dependency gatsby to 3.14.6 (apollographql#2123) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Edits to intro and installation docs (apollographql#2125) * Edits to intro and installation docs * Fix broken links * Edits from @designatednerd plus new screenshots * Fix tutorial URL and tweak downloading a schema article (apollographql#2133) * Split advanced "Creating a client" content into separate article (apollographql#2143) * WIP on revamp to Creating a client article * Break request chain content into separate article * Fix broken links * Incorporate feedback * Disable flaky integration test Will go back and fix this during WebSocket updates after 1.0 alpha * Update gatsby config to deploy 1.0 alpha docs * Update roadmap after 1.0.0-alpha.1 release (apollographql#2145) * [v1.0.0 Alpha 1] JavascriptError @unchecked Sendable (apollographql#2147) * fix: added unchecked sendable to JavascriptError to be able to compile with Swift 5.6 * Update CircleCI to use latest images * Change JavaScriptError properties to read-only * Fix typo in header doc Co-authored-by: TizianoCoroneo <tizianocoroneo@me.com> Co-authored-by: Calvin Cestari <calvin.cestari@gmail.com> * Update documentation to clarify schema download format and filename (apollographql#2160) * Update documentation to clarify schema download format and filename * Fix documentation link * chore(deps): update dependency follow-redirects to 1.14.8 [security] (apollographql#2161) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update license copyright notice * Delete Jazzy config - not supported * Update list of active maintainers * [Fix apollographql#2170] Do not refetch query watcher from server after cache miss when cache policy is cache only (apollographql#2177) * [Fix apollographql#2170] Do not refetch query watcher from server after cache miss when cache policy is cache only * Revert test broken test infra change * Add `graphql-ws` protocol support (apollographql#2168) * Implement graphql-transport-ws protocol support * Add graphql-transport-ws integration test based on Apollo Server docs-examples * Add CI step for Apollo Server graphql-transport-ws tests * After installing node v12 switch to use v16 * Instruct nvm to use version in .nvmrc * Update documentation and tutorial * Change WSProtocol cases to closer match library names * Remove initializer defaults and require web socket protocol on designated initializer. * Update Subscriptions documentation * Add WSProtocol option for AWS AppSync * Add ping/pong message support required by graphql-ws * Update documentation and tutorial * Add tests for subscriptionWsProtocol * Add tests for graphqlWSProtocol * Revert to naming aligned with the protocols and not the implementation libraries * Use longer async timeout for slower environments like CI * Fix test names * Fix project configuration * Rename protocol parameter on WebSocket initializers * Revert "Use longer async timeout for slower environments like CI" * Fix async timing bug and refactor websocket protocol tests * chore(deps): update dependency prismjs to 1.27.0 [security] (apollographql#2179) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Release 0.51.0 (apollographql#2086) * Update version number * Update changelog * Update SourceDocsLib dependecy * Update generated documentation * Update changelog with cache key caveat * Update changelog for merging of apollographql#2147 * Update changelog for apollographql#2177 and apollographql#2168 * Update documentation * Enable lazy access to the request body creation for leverage in custom built interceptors (apollographql#2184) * Release `0.51.1` (apollographql#2188) * Update project version * Update changelog for apollographql#2184 * Update documentation * Updates for new docs infra (apollographql#2197) * Prepare ios docs for new infra * Add sidebar config * Update ExpansionPanelList components * Update code fences * Move _redirects file * Fix links * Update docset title * Update sidebar config * Add version to ios docs config * Remove imports and fix links * Remove mb from homepage button * Add algolia filters * Remove files from old Gatsby docs theme (apollographql#2202) * Remove files from old Gatsby docs theme * Remove netlify.toml * Clear body on APQ retry in JSONRequest (apollographql#2206) * Release 0.51.2 (apollographql#2207) * Release 0.51.2 * Fix Package file * Fix changelog version. * Add netlify config for deploy previews (apollographql#2208) * Add netlify config for deploy previews * Trigger deploy * Remove circle config * Update docs repo branch * Use buttonlink component * Add codegen option for excludes (apollographql#2205) * Add exclude options * Add test case * Fix typo (apollographql#2212) * Start a docs production deploy when docs changes get merged (apollographql#2211) * Create docs-publish.yml * Tweak ignore command * Bump minimist from 1.2.5 to 1.2.6 in /SimpleUploadServer (apollographql#2214) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump node-fetch from 2.6.6 to 2.6.7 in /SimpleUploadServer (apollographql#2215) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.6 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.6...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add note to tutorial about the `graphql-ws` subscription library (apollographql#2219) * Add note to tutorial about new subscription library * tweak spacing * tweak phrasing * Add links and clarify which library is not maintained Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com> * Update tutorial-obtain-schema.md (apollographql#2225) Change extension of the downloaded schema file. * Update tutorial-execute-query.md (apollographql#2228) * Update tutorial-execute-query.md * Change the schema file type to json. * chore: Update Xcode build tool versions on CircleCI (apollographql#2242) * chose: update xcode build environment versions * fix: update Node version to match CircleCI image * chore: Update roadmap * fix: Sandbox documentation links (apollographql#2254) * ci: Update xcode image to fix Node version mismatch * ci: Update Node version to match what is installed with Xcode 13.3.1 image * chore: updates roadmap (apollographql#2258) * chore: updates roadmap * Update ROADMAP.md Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com> * Update ROADMAP.md Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com> Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com> * Update build phases example to propagate errors to Xcode (apollographql#2260) Without the explicit propagation I wasn't seeing errors in Xcode. Build phase shell env: `/bin/sh` Xcode version: `Version 13.2.1 (13C100)` * Add a comment about a new use of the X-APOLLO-OPERATION-NAME header (apollographql#2267) * Set permissions for GitHub actions (apollographql#2248) * updates roadmap for june 2022 (apollographql#2295) * Update CircleCI tool versions (apollographql#2304) * ci: Update Xcode and iOS simulator versions * ci: Update Node version * fix: `graphql_transport_ws` protocol should send 'complete' to end subscription (apollographql#2320) * fix: graphql_transport_ws protocol should send 'complete' to end subscription * fix: Require MockWebSocket to be initialized with a graphql subscriptions protocol * tests: Fix StarWarsSubscriptionTests to use updated MockWebSocket initializer * Replace print statement with CodegenLogger.log (apollographql#2348) * Fix buttons on docs root (apollographql#2369) * Expose GraphQLResultError Path String (apollographql#2361) * Expose the path as a String * tests: Add unit tests for ResponsePath Co-authored-by: Calvin Cestari <calvin.cestari@gmail.com> * Revert "Fix buttons on docs root (apollographql#2369)" (apollographql#2371) This reverts commit d26751a. * release: 0.52.0 (apollographql#2370) * chore: Update release version number * chore: Update changelog * dep: Update packages * docs: Update API reference * Fix typo (apollographql#2379) Removed duplicate "the" * Fix incorrect parameter name (apollographql#2380) `id` was set as a parameter, but the query expects `launchId`. * chore: Update ROADMAP for Beta release cycle (apollographql#2393) * Remove all instances of bitcode as not supported in Xcode 14 (apollographql#2398) https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes * Release 0.53.0 (apollographql#2406) * chore: Update version number * chore: Update CHANGELOG * fix: checkout at tag with legacy optionals behavior (apollographql#2412) * Update version in Swift Scripting docs (apollographql#2416) * Re-added support for iOS 11 * Update to 0.53.0 Co-authored-by: Anthony Miller <anthonymdev@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com> Co-authored-by: hwillson <hugh@octonary.com> Co-authored-by: Hesham Salman <iron-ham@github.com> Co-authored-by: Calvin Cestari <calvin.cestari@gmail.com> Co-authored-by: bogdanbeczkowski <bogdanbeczkowski@gmail.com> Co-authored-by: Ellen Shapiro <designatednerd@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Janessa Garrow <janessa@apollographql.com> Co-authored-by: Stephen Barlow <stephen@apollographql.com> Co-authored-by: TizianoCoroneo <tizianocoroneo@me.com> Co-authored-by: Calvin Cestari <calvin.cestari@apollographql.com> Co-authored-by: Rick Fast <rfast@expediagroup.com> Co-authored-by: Trevor Blades <tdblades@gmail.com> Co-authored-by: bannzai <kingkong999yhirose@gmail.com> Co-authored-by: Ayden Lee <lcmini6528@gmail.com> Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> Co-authored-by: Carrione <miroslav.tourek@gmail.com> Co-authored-by: Martin Bonnin <martin@mbonnin.net> Co-authored-by: JV <jvajda@apollographql.com> Co-authored-by: Adam Zethraeus <adam@zethrae.us> Co-authored-by: David Glasser <glasser@apollographql.com> Co-authored-by: neilnaveen <42328488+neilnaveen@users.noreply.github.com> Co-authored-by: Hilton Campbell <github@crosswaterbridge.com> Co-authored-by: Joshua Shroyer <98055534+joshuashroyer-toast@users.noreply.github.com> Co-authored-by: Mischa Hildebrand <web@mischa-hildebrand.de> Co-authored-by: stareque-atlassian <46062249+stareque-atlassian@users.noreply.github.com> Co-authored-by: Yuki Yamamoto <yymmt3.waste@gmail.com>

Update Package.swift and podspec

ee147b8

Updated XcodeProj

9fb8928

Iron-Ham marked this pull request as draft November 3, 2021 19:03

calvincestari mentioned this pull request Nov 3, 2021

Align platform versions in SPM manifest and Xcode project stephencelis/SQLite.swift#1094

Merged

calvincestari mentioned this pull request Nov 3, 2021

Decision Record - Defer support of SQLite.swift 0.13.0+ #1943

Closed

Bump SQLite.swift minimum required version to 0.13.1

978ba9a

This ensures all macOS targets can build with the reverted deployment target.

calvincestari marked this pull request as ready for review November 17, 2021 19:54

calvincestari added a commit that referenced this pull request Nov 17, 2021

Update changelog for #2015

676da54

calvincestari merged commit 46957a3 into apollographql:main Nov 17, 2021

calvincestari changed the title ~~Update SQLite.swift to version 13.0~~ Update SQLite.swift to version 13.1 Nov 17, 2021

calvincestari self-assigned this Nov 17, 2021

calvincestari added the 2021-11 label Nov 17, 2021

calvincestari added this to the Release 0.50.0 milestone Nov 17, 2021

calvincestari added a commit that referenced this pull request Nov 17, 2021

Release 0.50.0 (#2031)

d93568f

* Update version number for release * Updated changelog for release * Update documentation for release changes * Update changelog for #2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update SQLite.swift to version 13.1 #2015

Update SQLite.swift to version 13.1 #2015

Iron-Ham commented Nov 2, 2021

apollo-cla commented Nov 2, 2021

designatednerd commented Nov 2, 2021

calvincestari commented Nov 3, 2021

designatednerd commented Nov 3, 2021

designatednerd commented Nov 3, 2021

Iron-Ham commented Nov 3, 2021

calvincestari commented Nov 3, 2021 •

edited

Loading

Iron-Ham commented Nov 3, 2021

calvincestari commented Nov 3, 2021

calvincestari commented Nov 5, 2021

calvincestari commented Nov 10, 2021

calvincestari commented Nov 15, 2021

Iron-Ham commented Nov 15, 2021

calvincestari commented Nov 17, 2021

Update SQLite.swift to version 13.1 #2015

Update SQLite.swift to version 13.1 #2015

Conversation

Iron-Ham commented Nov 2, 2021

Overview

What do we get by upgrading to version 13.0?

What should we test?

apollo-cla commented Nov 2, 2021

designatednerd commented Nov 2, 2021

calvincestari commented Nov 3, 2021

designatednerd commented Nov 3, 2021

designatednerd commented Nov 3, 2021

Iron-Ham commented Nov 3, 2021

calvincestari commented Nov 3, 2021 • edited Loading

Iron-Ham commented Nov 3, 2021

calvincestari commented Nov 3, 2021

calvincestari commented Nov 5, 2021

calvincestari commented Nov 10, 2021

calvincestari commented Nov 15, 2021

Iron-Ham commented Nov 15, 2021

calvincestari commented Nov 17, 2021

calvincestari commented Nov 3, 2021 •

edited

Loading